Thread: [beginner] Proper capitalization

Hello there, trying to write a program to use proper capitalization on an input sentance. Here's what I have but its compiling and giving me back gobbildy-gook, can someone lend a hand? cheers. Shane.

Code:

#include <stdio.h>


int main(void)
{
        char text[200];
        int i = 0;
        
        printf("Enter text:");
        gets(text);


/*First letter is always capital*/


    if(text[i] > 96 && text[i] < 123)
    {
            text[i] = text[i] - 32;
            printf("%c", text[i]);
            i++;
    }
    else
    {
            printf("%c", text[i]);
    }


/*Eliminating random capitals throughout the sentance*/
    while(text[i] != '\0')
    {
        if(text[i] > 64 && text[i] < 91);
        {
                text[i] = text[i] + 32;
                printf("%c", text[i]);
        }
        
        if(text[i] > 96 && text[i] < 123)
        {
                printf("%c", text[i]);
        }        
        
        if(text[i] == '.')        //Capitalizing after a full stop
        {
                i = i + 2;        //i + 2 because there is a space after a full stop
            
            if(text[i] > 64 && text[i] < 91);
            {
                text[i] = text[i] + 32;
                printf("%c", text[i]);
            }
            
            if(text[i] > 96 && text[i] < 123)
            {
                printf("%c", text[i]);
            }        
        }
            i++;
    }
    
        
}

This is a pretty interesting idea.

if (char string[scanning int]>='A' && char string [scanning int] <='Z') It is ok to use 'a' or 'A' in an expression like this (with ascii anyway), so long as you have the ' ' around it to indicate constant character.

just looking at the output I got for it, it looks like you have at least 2 if loops operating on the same data. You could try setting it to print out the decimal values, feeding it different inputs, and tracing back through the program to find out what each if loop is doing to each variable.

I just started rewriting this into my own thing and noticed some things about your version that might help you in the future.

1. This sequence is before the while loop that limits the variable I (<-auto correct) from walking off the end of the array. Also, the intention isn't clear, you covered all cases where a letter and several symbols might be entered, and then subtracted 32 from everything. So lower case will be capitalized and everything else starts right after null.

Code:

    if(text[i] > 96 && text[i] < 123)
    {
            text[i] = text[i] - 32;
            printf("%c", text[i]);
            i++;
    }
    else
    {
            printf("%c", text[i]);
    }

2. The 1st& 4th, and the 2&5 if statements are the same.

3. I think the purpose was to capitalize things 2 spaces after a period, but you didn't make any changes to the array itself. Only caused the I variable to skip those spaces.

Code:

        if(text[i] == '.')       
        {
                i = i + 2;

4. When printing a character array it is ok to use the %s format, and name only the array (without the [I] scanning element added)

Hope any of this was helpful, and good luck!